search

asadm / playroom-unity

9 stars 1 forks source link

insertCoin's onDisconnect callback is wrong #33

Closed asadm closed 5 months ago

asadm commented 5 months ago

It's listening to onDisconnect(callback) instead of passing the callback to insertCoin itself (see here)

instead of .then .catch here, just use the right callbacks onLaunchCallback and onDisconnectCallback

https://github.com/asadm/playroom-unity/blob/aa3418e1125ae9accd48811aa2e81381422637f1/Assets/Plugins/PlayroomPlugin.jslib#L59

asadm commented 5 months ago

The signature for InsertCoin is ordered wrong? https://github.com/asadm/playroom-unity/blob/aa3418e1125ae9accd48811aa2e81381422637f1/Assets/PlayroomKit/PlayroomKit.cs#L58

it should be similar to how js version is.

momintlh commented 5 months ago

@asadm pushed fixes in #35.