asadm / playroom-unity

9 stars 1 forks source link

InsertCoin should return failure error reason #46

Closed asadm closed 2 months ago

asadm commented 3 months ago

instead of just printing, pass error back to dev

momintlh commented 3 months ago

Return the error message to unity from JS? This is also a part of #40

SaadBazaz commented 3 months ago

Return the error message to unity from JS? This is also a part of #40

It seems like a good idea to make the generic error handling mechanism as discussed in our refactor, but we need to plan it properly and do it within a reasonable timeframe.

momintlh commented 3 months ago

Return the error message to unity from JS? This is also a part of #40

It seems like a good idea to make the generic error handling mechanism as discussed in our refactor, but we need to plan it properly and do it within a reasonable timeframe.

InsertCoin is a good start for this, just returning the error message to unity should be enough after catching it, instead of printing.

momintlh commented 2 months ago

Current progress of this issue in #49:

Improvements:

SaadBazaz commented 2 months ago

49 implements a basic error-passing mechanism. As we keep improving this mechanism, we will create more Issues in the future.