mock mode differences from real web mode

[asadm]

https://discord.com/channels/997752993598419044/1224804678089445386/1224804678089445386

[momintlh]

The OnPlayerJoin change was due to only 1 player being allowed during MockMode, I guess for this issuse we just need to call the OnPlayerJoinWrapperCallback within mockmode as well.

[SaadBazaz]

The OnPlayerJoin change was due to only 1 player being allowed during MockMode, I guess for this issuse we just need to call the OnPlayerJoinWrapperCallback within mockmode as well.

How would that resolve the Kick issue? What is your understanding of that problem?

[momintlh]

The OnPlayerJoin change was due to only 1 player being allowed during MockMode, I guess for this issuse we just need to call the OnPlayerJoinWrapperCallback within mockmode as well.

How would that resolve the Kick issue? What is your understanding of that problem?

Kick() was never implemented in MockMode before. Considering the player in mock mode is a host, we just need to remove / destroy that player object? I think we might need to introduce 2 players within mockmode : 1 host and another non-host, to accurately simulate Kick() as the web version.

[SaadBazaz]

Kick() was never implemented in MockMode before. Considering the player in mock mode is a host, we just need to remove / destroy that player object? I think we might need to introduce 2 players within mockmode : 1 host and another non-host, to accurately simulate Kick() as the web version.

I agree, that would allow the developer to test more usecases. How would the second user work, though? Would it mirror everything player1 does?

[momintlh]

Kick() was never implemented in MockMode before. Considering the player in mock mode is a host, we just need to remove / destroy that player object? I think we might need to introduce 2 players within mockmode : 1 host and another non-host, to accurately simulate Kick() as the web version.

I agree, that would allow the developer to test more usecases. How would the second user work, though? Would it mirror everything player1 does?

We can disable input for the second player.

[SaadBazaz]

Kick Issue is solved.

@momintlh have we solved this in #50 ?

[momintlh]

Kick Issue is solved.

@momintlh have we solved this in #50 ?

From #50 ^

[SaadBazaz]

Just in case, we should scan the code to see if we've left some mistakes/inconsistencies like this anywhere else.