search

asadm / playroom-unity

9 stars 1 forks source link

Make all non-upstream functions private #72

Closed SaadBazaz closed 1 month ago

SaadBazaz commented 1 month ago

What happened?

hey, I just figure out that there is a GetPlayerState in the Player class. How is it different from GetState?

Possible solution

Any function which isn't in PlayroomKit JS SDK, should be private in Unity SDK. So we have complete feature parity.

Version

0.0.22

What is your environment?

Unknown

Link to original discussion

https://discord.com/channels/997752993598419044/1128151935669764096/1240665682782453825 Related: https://discord.com/channels/997752993598419044/1128151935669764096/1240729357513916416

Relevant log output

image

SaadBazaz commented 1 month ago

You might also want to read this thread, @momintlh : https://discord.com/channels/997752993598419044/1128151935669764096/1240729357513916416

This developer has a lot of good points. We can clean up our implementation better, and make the DX cleaner for developers.

Tagging #40 as it seems related.

momintlh commented 1 month ago

Will fix this today.

SaadBazaz commented 1 month ago

Solved in #73 , released in v0.0.23