BatchNodes cannot batch subclasses of Geometry

[GoogleCodeExporter]

BatchNodes cannot batch Spatials that are subclasses of Geometry because in the 
gatherGeometries method, the Geometry class is explicitly checked for:

===
if (n.getClass() == Geometry.class) {
===

This is different from the behavior of GeometryBatchFactory.gatherGeoms, which 
uses instanceof instead.

Original issue reported on code.google.com by roja...@gmail.com on 7 Feb 2012 at 7:44

[GoogleCodeExporter]

it should check assignability instead @remy

Original comment by normen667 on 7 Feb 2012 at 12:09

• Changed state: Accepted
• Added labels: Product-jME3

[GoogleCodeExporter]

It's a known issue.
I did this at first because not all subclasses can be batched (particle 
emitters mostly), but now that there is the batchHint i guess i could use 
instanceof and default the batchHint of ParticleEmitter to never...

Original comment by remy.bou...@gmail.com on 7 Feb 2012 at 12:43

[GoogleCodeExporter]

Hm, ok. Generally its not a good idea to subclass Geometry anyway.. Except they 
are so special that they probably would not work for batching anyway, like 
terrain and particle emitters.. Setting the priority to "low", people who 
subclass Geometry to add some methods or data should use Controls anyway.

Original comment by normen667 on 7 Feb 2012 at 2:11

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

fixed

Original comment by remy.bou...@gmail.com on 22 Dec 2012 at 3:20

• Changed state: Fixed

[GoogleCodeExporter]

This issue was closed by revision r10040.

Original comment by remy.bou...@gmail.com on 22 Dec 2012 at 3:20