search

asafbibas / jmonkeyengine

Automatically exported from code.google.com/p/jmonkeyengine
0 stars 0 forks source link

Patch for /trunk/engine/src/core/com/jme3/app/FlyCamAppState.java #474

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Make setCamera() public so it can be accessed from SimpleApplication

Original issue reported on code.google.com by playny...@gmail.com on 25 Feb 2012 at 6:25

Attachments:

GoogleCodeExporter commented 8 years ago 
I do not exactly understand the purpose of this patch. It seems to me that 
changing the FlyByCam should not be allowed on the AppState.

Original comment by ShadowIs...@gmail.com on 1 Jun 2012 at 3:43

GoogleCodeExporter commented 8 years ago 
Agreed.  That patch is no good anyway as it does not remove the existing camera 
and all of its goodies and it does not attach the new camera.  If a method is 
to be public then it should be properly implemented so as not to require 
calling only from one specific method.

And anyway, I think if someone wants a different camera then they should write 
their own app state.

Original comment by PSpee...@gmail.com on 1 Jun 2012 at 4:39

GoogleCodeExporter commented 8 years ago

Original comment by ShadowIs...@gmail.com on 1 Jun 2012 at 4:41