Closed alexilyaev closed 8 years ago
Sounds like a great idea, would you like to pull request ?
On Fri, Sep 25, 2015 at 3:44 PM, Alex Ilyaev notifications@github.com wrote:
Can we add support for loading the ngCsv as a CommonJS module?
See example of Angular UI-Router:
https://github.com/angular-ui/ui-router/blob/master/release/angular-ui-router.js
This will allow doing:
var ngCsv = require('ng-csv');
angular.module('admin', [ ngCsv ])
Instead of hard coding the module name.
— Reply to this email directly or view it on GitHub https://github.com/asafdav/ng-csv/issues/119.
Cool, when can we expect it to be on NPM?
Now :) I'd appreciate it if you could report back that it works well for you.
Confirmed.
Great thank you!
On Tue, Sep 29, 2015 at 11:53 AM, Alex Ilyaev notifications@github.com wrote:
Confirmed.
— Reply to this email directly or view it on GitHub https://github.com/asafdav/ng-csv/issues/119#issuecomment-143993205.
Can we add support for loading the ngCsv as a CommonJS module?
See example of Angular UI-Router: https://github.com/angular-ui/ui-router/blob/master/release/angular-ui-router.js
This will allow doing:
Instead of hard coding the module name.