asafdav / ng-csv

Simple directive that turns arrays and objects into downloadable CSV files
MIT License
573 stars 215 forks source link

Add commonjs package manager support #119

Closed alexilyaev closed 8 years ago

alexilyaev commented 8 years ago

Can we add support for loading the ngCsv as a CommonJS module?

See example of Angular UI-Router: https://github.com/angular-ui/ui-router/blob/master/release/angular-ui-router.js

This will allow doing:

var ngCsv = require('ng-csv');

angular.module('admin', [
    ngCsv
])

Instead of hard coding the module name.

asafdav commented 8 years ago

Sounds like a great idea, would you like to pull request ?

On Fri, Sep 25, 2015 at 3:44 PM, Alex Ilyaev notifications@github.com wrote:

Can we add support for loading the ngCsv as a CommonJS module?

See example of Angular UI-Router:

https://github.com/angular-ui/ui-router/blob/master/release/angular-ui-router.js

This will allow doing:

var ngCsv = require('ng-csv');

angular.module('admin', [ ngCsv ])

Instead of hard coding the module name.

— Reply to this email directly or view it on GitHub https://github.com/asafdav/ng-csv/issues/119.

alexilyaev commented 8 years ago

Cool, when can we expect it to be on NPM?

asafdav commented 8 years ago

Now :) I'd appreciate it if you could report back that it works well for you.

alexilyaev commented 8 years ago

Confirmed.

asafdav commented 8 years ago

Great thank you!

On Tue, Sep 29, 2015 at 11:53 AM, Alex Ilyaev notifications@github.com wrote:

Confirmed.

— Reply to this email directly or view it on GitHub https://github.com/asafdav/ng-csv/issues/119#issuecomment-143993205.