search

asafdav / ng-csv

Simple directive that turns arrays and objects into downloadable CSV files
MIT License
573 stars 215 forks source link

Multi-csv feature added, display export data on the example site #132

Closed shaohaolin closed 8 years ago

shaohaolin commented 8 years ago

Multi-csv feature:

When multi-csv is set it to true, it allows to convert an object of nested arrays to different csv in one file. Sampe input data: { managers: [ {name: John, age: 45}, {name: Matt, age: 36}], employees: [ {name: Justin, gender: male, age:27, {name: Mary, gender: female, age: 22}, {name: Joe, gender: male, age 31}}] } Output csv: 1

Display sample data on the site:

Being able to display the sample on the site helps to understand what kind of data can be convert to csv using ng-csv directive. capture

shaohaolin commented 8 years ago

@asafdav I have finished the feature, let me know what you think :)

asafdav commented 8 years ago

Hi @shaohaolin sorry it's was rough recently, would you mind squashing your commits ? in the meantime I'll start reviewing your pull request, seems awesome

shaohaolin commented 8 years ago

@asafdav Thank you for the reply!!! I don't mind to squash the commits. But how can I do that? What' the general steps?

frankmariette commented 8 years ago

@shaohaolin here is a link explaining how to do it. http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git. Also push -f after you squash the commits to the history is rewritten with just 1 commit.

shaohaolin commented 8 years ago

I am going to squash the commits and make a new one.