search

asafdav / ng-csv

Simple directive that turns arrays and objects into downloadable CSV files
MIT License
573 stars 215 forks source link

Fixes IE and Safari utilizing feature checks #139

Open frankmariette opened 8 years ago

frankmariette commented 8 years ago

Added in fixes for IE and Safari. The Safari "fix" just writes the data to a URI and allows it to be saved as a csv with the page source. Didn't want to use a polyfill for flash with the recent vulnerabilities for Flash. While this isn't ideal it is better than nothing. The IE fix was originally created by @BerangereMartin and I modified it to work with the current version of ng-csv.

asafdav commented 8 years ago

Hi can you please squash your commits ?

frankmariette commented 8 years ago

@asafdav Squashed them down.

asafdav commented 8 years ago

Hi @karrde00, you need to push -f after a squash otherwise all of the old commits stay and it leads to issues. there should be only one commit under the commit tab (currently 11)

asafdav commented 8 years ago

Thanks again

frankmariette commented 8 years ago

@asafdav Fixed it. Thanks for the help on the squash.

frankmariette commented 8 years ago

@asafdav What's the status on this?

eraye1 commented 8 years ago

curious about the status of this as well.

qdequippe commented 7 years ago

+1 to merge this PR