search

asafdav / ng-csv

Simple directive that turns arrays and objects into downloadable CSV files
MIT License
573 stars 215 forks source link

Allow any 1.* version for angular #199

Open CaporalDead opened 7 years ago

CaporalDead commented 7 years ago

You shouldn't force users to pull only latest major version of angular and dep. ~1 prevent the use of angular 1.5.*.

Change to ~1.0

wildgarden commented 7 years ago

@CaporalDead Your propose solution supports only versions in the range > 1.0 and < 1.1. You have to change the operator from ~ to ^. Convince yourself here: https://semver.npmjs.com/ . Please check my pull-request: https://github.com/digitaleo/ng-csv/pull/1

CaporalDead commented 7 years ago

@wildgarden true, we changed it on our private repo and I did not reflect this change on the public github fork we have. I'll fix it tomorrow. Thx for your feedback :).

CaporalDead commented 7 years ago

@wildgarden updated with your proposal

wildgarden commented 7 years ago

@CaporalDead Thanks, for your fast response. :+1: