asafdav / ng-csv

Simple directive that turns arrays and objects into downloadable CSV files
MIT License
573 stars 215 forks source link

MAJOR performance improvement by changing one line. #95

Closed pursual closed 9 years ago

pursual commented 9 years ago

In the csv-service.js get rid of: responseData = angular.copy(responseData);

Instead do it at the time of row creation:

angular.forEach(arrData, function (oldNoLongerUsedRow, index) { var row = angular.copy(arrData[index]); var dataString, infoArray;...

asafdav commented 9 years ago

Can you please pull request ?

pursual commented 9 years ago

Submitted. #96

asafdav commented 9 years ago

Great stuff, thank you!