Fix for last newline - Githubissues

asafdav / ng-csv

Simple directive that turns arrays and objects into downloadable CSV files

MIT License

573 stars 215 forks source link

Open pursual opened 9 years ago

pursual commented 9 years ago

I'm not in a position to test this on your latest as I have highly customized an older version, but this fix probably still applies.

pursual commented 9 years ago

Looks like the tests do not account for the feature.

asafdav commented 9 years ago

Thanks, can you please explain why you needed this fix ?

pursual commented 9 years ago

It avoids having an extra newline at the end of the CSV. I did not need it at all, I just saw the bug in the existing code.

asafdav commented 9 years ago

Sorry I didn't look at the right code, I'll check this manually. thanks