search

asafdav / ng-scrollbar

A custom scrollbar written in pure AngularJS
MIT License
187 stars 70 forks source link

event and flag for scrollbar presence #15

Closed subarroca closed 10 years ago

asafdav commented 10 years ago

Hi,
First of all, thank you for this pull request !

Few comments: 1) Isolated scope might be tricky here and could lead to some issues, is there any good reason for that ? 2) It seems like is-bar-shown is required and if you won't provide it it will lead to an error

subarroca commented 10 years ago

I use an isolated scope to inform parent through a variable. I know no other way. And so far I've come with no other problems with the isolation. If you know a way to do that I'll be happy to add it

I'm pushing a change so the param is now optional.

Thanks for your effort and your comments

asafdav commented 10 years ago

Sorry for the super late response, I'll do my best to merge your pull request ASAP.

Thanks again.