search

asagi4 / comfyui-prompt-control

ComfyUI nodes for prompt editing and LoRA control
GNU General Public License v3.0
165 stars 14 forks source link

PromptControlSimple not in Readme #25

Closed ghostsquad closed 6 months ago

ghostsquad commented 6 months ago

Is PromptControlSimple part of this repo? If so, is it a deprecated node? It's not in the README, so I'm not sure what the expected behavior is.

image

asagi4 commented 6 months ago

It is in the repo. I seem to have forgotten it from the README.

It's just a convenience node that's a combination of the primary nodes (PromptToSchedule, ScheduleToCond, ScheduleToModel and FilterSchedule)

ghostsquad commented 6 months ago

Ah thanks! Ya, I think ComfyUI needs a better way to document node functionality. 😂 Right now, I kinda rely on the information in the README and if things get hairy, I'll try to find/read the code. Thanks for updating the README. 😄

ghostsquad commented 6 months ago

By chance can you explain the tags, start, and end fields on this node?

image

Also, not sure if this is a bug here, or in ComfyUI, as it seems those 3 fields escape the boundary of the node itself.

asagi4 commented 6 months ago

See the FilterSchedule node for an explanation of those. They are used to apply filtering to the schedule if you want to do a two-pass workflow for example.

And yeah, that's a bug in ComfyUI or you have some UI extension that breaks things a bit.