search

asagi4 / comfyui-prompt-control

ComfyUI nodes for prompt editing and LoRA control
GNU General Public License v3.0
165 stars 14 forks source link

SamplerCustom is referencing cfg as the step count when scheduling Lora #34

Closed pyomyofiro closed 4 months ago

pyomyofiro commented 4 months ago

SamplerCustom is referencing cfg as the step count when scheduling Lora rapture_20240319225456 rapture_20240319225605 rapture_20240319225649 rapture_20240319225725

When I want to use SamplerCustom, I am manually altering this part to the actual step count value. rapture_20240319225932

asagi4 commented 4 months ago

Hm. Looks like the sample_custom function needs a completely different hijack, since the steps value isn't even available.

I never use the custom sampler nodes, so I never noticed this.

asagi4 commented 4 months ago

The above commit isn't a perfect fix since some samplers discard the penultimate sigma, but it's close enough that I'll consider this issue fixed.