search

asagi4 / comfyui-prompt-control

ComfyUI nodes for prompt editing and LoRA control
GNU General Public License v3.0
182 stars 16 forks source link

Some parts of Scheduling syntax are not understood. #55

Closed ytoaa closed 1 month ago

ytoaa commented 1 month ago

image image I think 0.8 means 80%, so I have to stop Laura after proceeding to step 16, which is 80% from step 20, but I only apply it to step 5, and stop Laura.

After a few attempts I found out this was responding to cfg...

asagi4 commented 1 month ago

Hm. Can I get a workflow to debug this?

ytoaa commented 1 month ago

workflow (3) I still don't know why it's responding to cfg and not step.

I noticed that this problem occurs when I use the "KSampler (inspire)" node.

Also, I found out that the same problem is occurring in other inspire family ksampler.

This is also a separate question. Can only the --highvram option disable cpu_offload? Is there any other way?

asagi4 commented 1 month ago

The PC override of the LoRA offload device on OOM happens regardless of ComfyUI options if you haven't disabled it, but without --highvram or --gpu-only the offload device may already be the CPU, in which case the behaviour simply doesn't change.

asagi4 commented 1 month ago

Anyway, the latest commit should fix this issue. It was a problem with detecting custom samplers (required because the function prototypes are different) that seems to trigger whenever there are other monkeypatches, and since the Inspire sampler uses the custom sampling function from ComfyUI, it mixed up CFG and steps

ytoaa commented 1 month ago

Anyway, the latest commit should fix this issue. It was a problem with detecting custom samplers (required because the function prototypes are different) that seems to trigger whenever there are other monkeypatches, and since the Inspire sampler uses the custom sampling function from ComfyUI, it mixed up CFG and steps

[INFO] PromptControl: SamplerCustom detected, number of steps not available. LoRA schedules will be calculated based on the number of sigmas (11)

When I try with ksampler (inspire), I get the following phrase on the console, what do you mean? It doesn't come out of the usual ksampler.

asagi4 commented 1 month ago

@ytoaa it just means that instead of the step count to calculate the point at which LoRAs change, the number of sigmas are used. For some samplers, the number of sigmas doesn't always match the number of configured steps. You'll note it says (11) there, meaning the calculation is done with 11 steps instead of 10.

The step count isn't available to the custom sampler function I hook into, which Inspire uses, so I have to use the sigmas instead.