search

asagi4 / comfyui-prompt-control

ComfyUI nodes for prompt editing and LoRA control
GNU General Public License v3.0
210 stars 16 forks source link

[FR] Flux Support? #57

Open ghostsquad opened 3 months ago

ghostsquad commented 3 months ago

Has this been tested to work with Flux?

asagi4 commented 3 months ago

I had a local modification to make flux not error out.

The support isn't complete; prompt styles don't work with flux, but with the latest commit on the master branch, you should at least be able to run the node with flux's CLIP.

As for LoRA loading, I have no idea; I barely have enough VRAM to run flux at all, so I haven't tested LoRAs.

DrJKL commented 3 months ago

Yeah, Flux LoRAs cause an OOM for me pretty frequently.

Lion-Lawliet commented 2 months ago

I tested it here, it seems LoRA doesn't get loaded at all, I don't see a change in VRAM nor the image changes as well.

Edit: Turns out the code doesn't support SamplerCustomAdvanced, which why it hasn't loaded any LoRAs. But I can confirm it causes OOM issues for some reason.

asagi4 commented 2 days ago

This is likely to improve as ComfyUI patch hooks PR gets merged. Follow #63 and check out the patch_hooks branch to try out the new nodes.