[BUG] in the example workflow

asagi4 / comfyui-prompt-control

ComfyUI nodes for prompt editing and LoRA control

GNU General Public License v3.0

210 stars 16 forks source link

Closed miasik closed 2 months ago

miasik commented 2 months ago

Could you please review your example https://github.com/asagi4/comfyui-prompt-control/blob/master/workflows/example.json?raw=1 I see "PCApplySettings" is not connected As I understand it has to be connected both to "ScheduleToCond" and "ScheduleToModel"

asagi4 commented 2 months ago

Huh. Well, I'll fix that at some point.

miasik commented 2 months ago

Huh. Well, I'll fix that at some point.

Also, please, add "PCSplitSampling" to the example

miasik commented 2 months ago

I've finally managed to properly connect "PCSplitSampling" but I also found an incompatibility with some "ComfyUI-Impact-Pack" nodes: https://github.com/ltdrdata/ComfyUI-Impact-Pack/issues/751

asagi4 commented 2 months ago

I redid the example workflow. I removed some of the more obscure features from it but added eg. custom mask usage.

miasik commented 2 months ago

I redid the example workflow. I removed some of the more obscure features from it but added eg. custom mask usage.

I see "PCSplitSampling" right after "Load Checkpoint". Don't I have to place it at exactly before KSampler?

asagi4 commented 2 months ago

@miasik I'm pretty sure it should work in either position since all it does is set a flag in model_options