search

asah / footprint2009dev

original dev repo for AllForGood.org
http://AllForGood.org/
0 stars 1 forks source link

consumer UI isn't passing urlparams it doesn't recognize #163

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
when I manually add &vol_dist=NNN to the consumer UI URLs,
I'm redirected to an url without this parameter.

this strikes me as an architectural flaw, i.e. we shouldn't
have to add urlparams in multiple places, to have them handled
properly.

anyway, this makes testing kinda hard... e.g. I wanted to check
on nationwide listings, and the easiest way is to set a gigantic
vol_dist

Original issue reported on code.google.com by adam.sah on 12 May 2009 at 3:57

GoogleCodeExporter commented 9 years ago 
Can you post the specific URLs that aren't responding correctly?

Original comment by paul.rademacher on 13 May 2009 at 1:36

GoogleCodeExporter commented 9 years ago 
sure:
http://footprint2009dev.appspot.com/search#q=Homeless&vol_dist=100

redirects to:
http://footprint2009dev.appspot.com/search#q=Homeless&num=10&start=1&vol_loc=29.
957%2
C-90.077&timeperiod=everything&cache=1

(this will happen for every urlparam not specifically whitelisted by the 
redirect
algorithm)

Original comment by adam.sah on 13 May 2009 at 12:51

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 16 May 2009 at 7:34

GoogleCodeExporter commented 9 years ago 
FYI this also hoses our ability to test non-production search backends,
e.g. &customer= to hit the test Base account

but in general, it's bad juju that the consumer UI is picking and choosing
urlparams to pass down the line.

leaving at High priority-- testers can use /api/volopps&customer=

Original comment by adam.sah on 19 May 2009 at 5:09

GoogleCodeExporter commented 9 years ago 
putting back on my plate

Original comment by adam.sah on 28 May 2009 at 5:08

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 5 Jun 2009 at 2:45

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 14 Jun 2009 at 2:05

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 28 Jun 2009 at 4:25