search

asah / footprint2009dev

original dev repo for AllForGood.org
http://AllForGood.org/
0 stars 1 forks source link

Show other likes on results #200

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
If someone outside the user friends has liked an event, we only show those 
"other" likes once the user or their friend likes it. 

We should show these other likes independent if the user or his friends 
have liked that event.

For example,

http://footprint2009dev.appspot.com/search#num=10&start=11&vol_loc=dorchest
er&timeperiod=everything&cache=1 

Do a map search for "Dorchester" and don't put anything keywords.

If you go to the second page, this item has been liked by three facebook 
accounts:

GED Writing and Reading at X-Cel Adult Education (Dorchester)
Dorchester MA 02122 - May 12
X-Cel, Inc. Adult Education was founded in 2000 by two adult educators with 
the vision of providing quality adult education services to residents of 
Greater Boston. X-Cel's mission is to make high school completion and 
college-level study more accessible to low-income adults in ...
http://www.bostoncares.org - Like - Add to calendar 

We don't show the other likes here.  Now, if I log in and like it using an 
account, I see this:

GED Writing and Reading at X-Cel Adult Education (Dorchester)
Dorchester MA 02122 - May 12
X-Cel, Inc. Adult Education was founded in 2000 by two adult educators with 
the vision of providing quality adult education services to residents of 
Greater Boston. X-Cel's mission is to make high school completion and 
college-level study more accessible to low-income adults in ...
http://www.bostoncares.org - Add to calendar
[smile] You and 3 more liked this (undo)

Original issue reported on code.google.com by kar...@gmail.com on 13 May 2009 at 12:40

GoogleCodeExporter commented 9 years ago 
What's the wording? 

"1 other liked this"
"3 others liked this"

...?

Original comment by manz...@gmail.com on 13 May 2009 at 12:55

GoogleCodeExporter commented 9 years ago 
moving this to 1.1 as it is non-critical.

Original comment by manz...@gmail.com on 16 May 2009 at 11:31

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 19 May 2009 at 6:48

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 20 May 2009 at 5:14

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 20 May 2009 at 5:19

GoogleCodeExporter commented 9 years ago 
Would be nice if we start to show this for 1.1

Original comment by kar...@gmail.com on 20 May 2009 at 5:27

GoogleCodeExporter commented 9 years ago 
I'm looking into this.

Original comment by jblockso...@gmail.com on 27 May 2009 at 4:38

GoogleCodeExporter commented 9 years ago 
So there's a couple things going on with this. On the display side, the 
information about who likes this isn't 
being displayed in snippets_list.js unless the user is listed as liking it. 
I've got a patch for this which I'll submit 
for review after this update. But before the information even gets here it 
seems to be being dropped, or never 
generated -- I'm looking into this part now, I currently think it's in 
view_helper.py but haven't nailed it down for 
sure yet.

Original comment by jblockso...@gmail.com on 27 May 2009 at 8:51

GoogleCodeExporter commented 9 years ago 
Review is at http://footprint2009reviews.appspot.com/24030 if you're playing 
along at home

Original comment by jblockso...@gmail.com on 28 May 2009 at 2:38

GoogleCodeExporter commented 9 years ago 
r661 fixed the server side of this, 
http://footprint2009reviews.appspot.com/25034 is the new review for the 
client side.

Original comment by jblockso...@gmail.com on 1 Jun 2009 at 5:41

GoogleCodeExporter commented 9 years ago

Original comment by adam.sah on 5 Jun 2009 at 2:45

GoogleCodeExporter commented 9 years ago 
Raising to Critical for 1.5 so we can get this code review and added....

Original comment by kar...@gmail.com on 9 Jun 2009 at 4:19

GoogleCodeExporter commented 9 years ago 
Ok, I did the code review for jblocksom's client-side CL, at Paul's request (it 
got
lost in the recent mad shuffle).  Hopefully after submitting that, this can be 
closed (?)

Original comment by manz...@gmail.com on 14 Jun 2009 at 9:19

GoogleCodeExporter commented 9 years ago 
Resolved in r755, marking as fixed. Thanks Tim for the review.

Original comment by jblockso...@gmail.com on 15 Jun 2009 at 3:31

GoogleCodeExporter commented 9 years ago 
Re-opening.  Karen saw problems.

Original comment by paul.rademacher on 16 Jun 2009 at 10:31

GoogleCodeExporter commented 9 years ago 
Fixed by Tim as part of issue 392.

Original comment by jblockso...@gmail.com on 17 Jun 2009 at 6:09

GoogleCodeExporter commented 9 years ago 
We are still not showing "other likes" when the user is NOT logged in.  

We should show "other likes" in these cases:
1) user is NOT logged in
2) user is logged in, but hasn't liked that event
3) user is logged in, and also liked that event

Original comment by kar...@gmail.com on 24 Jun 2009 at 6:24