Open GoogleCodeExporter opened 9 years ago
What's the wording?
"1 other liked this"
"3 others liked this"
...?
Original comment by manz...@gmail.com
on 13 May 2009 at 12:55
moving this to 1.1 as it is non-critical.
Original comment by manz...@gmail.com
on 16 May 2009 at 11:31
Original comment by adam.sah
on 19 May 2009 at 6:48
Original comment by adam.sah
on 20 May 2009 at 5:14
Original comment by adam.sah
on 20 May 2009 at 5:19
Would be nice if we start to show this for 1.1
Original comment by kar...@gmail.com
on 20 May 2009 at 5:27
I'm looking into this.
Original comment by jblockso...@gmail.com
on 27 May 2009 at 4:38
So there's a couple things going on with this. On the display side, the
information about who likes this isn't
being displayed in snippets_list.js unless the user is listed as liking it.
I've got a patch for this which I'll submit
for review after this update. But before the information even gets here it
seems to be being dropped, or never
generated -- I'm looking into this part now, I currently think it's in
view_helper.py but haven't nailed it down for
sure yet.
Original comment by jblockso...@gmail.com
on 27 May 2009 at 8:51
Review is at http://footprint2009reviews.appspot.com/24030 if you're playing
along at home
Original comment by jblockso...@gmail.com
on 28 May 2009 at 2:38
r661 fixed the server side of this,
http://footprint2009reviews.appspot.com/25034 is the new review for the
client side.
Original comment by jblockso...@gmail.com
on 1 Jun 2009 at 5:41
Original comment by adam.sah
on 5 Jun 2009 at 2:45
Raising to Critical for 1.5 so we can get this code review and added....
Original comment by kar...@gmail.com
on 9 Jun 2009 at 4:19
Ok, I did the code review for jblocksom's client-side CL, at Paul's request (it
got
lost in the recent mad shuffle). Hopefully after submitting that, this can be
closed (?)
Original comment by manz...@gmail.com
on 14 Jun 2009 at 9:19
Resolved in r755, marking as fixed. Thanks Tim for the review.
Original comment by jblockso...@gmail.com
on 15 Jun 2009 at 3:31
Re-opening. Karen saw problems.
Original comment by paul.rademacher
on 16 Jun 2009 at 10:31
Fixed by Tim as part of issue 392.
Original comment by jblockso...@gmail.com
on 17 Jun 2009 at 6:09
We are still not showing "other likes" when the user is NOT logged in.
We should show "other likes" in these cases:
1) user is NOT logged in
2) user is logged in, but hasn't liked that event
3) user is logged in, and also liked that event
Original comment by kar...@gmail.com
on 24 Jun 2009 at 6:24
Original issue reported on code.google.com by
kar...@gmail.com
on 13 May 2009 at 12:40