QOD: /ui_snippets?q=park&cache=1

[GoogleCodeExporter]

QOD=(query of death)

seems like we're not checking for null vol_loc in ui_snippets?
i.e. looks like loc is None in the code below...

please fix & add to test suite... not sure if this is urgent,
since homepage tries to run location-ful queries I think?

05-19 01:34AM 20.113 /ui_snippets?q=park&cache=1 500 100ms 87cpu_ms 0kb 
curl/7.18.2 (x86_64-pc-linux-gnu) libcurl/7.18.2 OpenSSL/0.9.8g 
zlib/1.2.3.3 libidn/1.10,gzip(gfe)
216.27.182.83 - - [19/May/2009:01:34:20 -0700] "GET /ui_snippets?
q=park&cache=1 HTTP/1.1" 500 124 - "curl/7.18.2 (x86_64-pc-linux-gnu) 
libcurl/7.18.2 OpenSSL/0.9.8g zlib/1.2.3.3 libidn/1.10,gzip(gfe)" 
"footprint2009dev.appspot.com"
E 05-19 01:34AM 20.207
expected string or buffer
Traceback (most recent call last):
  File 
"/base/python_lib/versions/1/google/appengine/ext/webapp/__init__.py", line 
501, in __call__
    handler.get(*groups)
  File 
"/base/data/home/apps/footprint2009dev/1.333579404837620069/views.py", line 
202, in decorate
    return handler_method(self)
  File 
"/base/data/home/apps/footprint2009dev/1.333579404837620069/views.py", line 
391, in get
    if not geocode.is_latlong(loc) and not geocode.is_latlongzoom(loc):
  File 
"/base/data/home/apps/footprint2009dev/1.333579404837620069/geocode.py", 
line 29, in is_latlong
    return (re.match(r'[0-9.+-]+\s*,\s*[0-9.+-]+', instr) != None)
  File "/base/python_dist/lib/python2.5/re.py", line 137, in match
    return _compile(pattern, flags).match(string)
TypeError: expected string or buffer

QODs are set to Critical by convention, though for footprint we may choose 
High instead.

Original issue reported on code.google.com by adam.sah on 19 May 2009 at 8:42

[GoogleCodeExporter]

Original comment by adam.sah on 20 May 2009 at 5:14

• Added labels: ConsumerUI

[GoogleCodeExporter]

Original comment by mt1...@gmail.com on 28 May 2009 at 1:57

• Changed state: Fixed