asah / footprint2009dev

original dev repo for AllForGood.org
http://AllForGood.org/
0 stars 1 forks source link

Admin page gives unauthorized instead of redirect if not logged in #447

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. At the command line, run:
curl -i http://www.allforgood.org/admin
2. The result is HTTP 401, Unauthorized

What is the expected output? What do you see instead?
It should be 302, page has moved. Without the 302 the RPC handlers don't know 
to go to the sign 
in page.

Note that if the user is logged in but not an administrator they should get the 
401 page.

Original issue reported on code.google.com by jblockso...@gmail.com on 22 Jun 2009 at 8:04

GoogleCodeExporter commented 9 years ago
sorry... is this a priority?

Original comment by adam.sah on 22 Jun 2009 at 8:07

GoogleCodeExporter commented 9 years ago
It messes up using appengine_rpc to log in and then flush the cache. It's 
mostly high because flushing the cache 
is high. I'm putting it down to medium but I'm also about to send you a review 
on it :).

Note that the admin stuff in general could use some cleaning up; while this is 
an easy fix the code it relies on 
code be removed altogether if we cleaned it up a bit.

Original comment by jblockso...@gmail.com on 22 Jun 2009 at 8:50

GoogleCodeExporter commented 9 years ago
Review submitted: http://footprint2009reviews.appspot.com/34001

Original comment by jblockso...@gmail.com on 23 Jun 2009 at 2:15

GoogleCodeExporter commented 9 years ago
Fixed in r883.

Original comment by jblockso...@gmail.com on 23 Jun 2009 at 9:06