asaini / Apriori

Python Implementation of Apriori Algorithm for finding Frequent sets and Association Rules
MIT License
771 stars 435 forks source link

Sample Input file compatible for UNIX systems (vim) #16

Closed raj454raj closed 4 years ago

raj454raj commented 8 years ago

@asaini : Please review ?

asaini commented 8 years ago

@raj454raj

  1. How easy was it to make this change? Did you use some utility(like dos2unix) for making this change?
  2. Is this change easily reversible? (for someone not in a UNIX environment)
raj454raj commented 8 years ago

Hey @asaini :

  1. Pretty easy - http://its.ucsc.edu/unix-timeshare/tutorials/clean-ctrl-m.html, But figuring out that the problem was ^M characters was not easy at all as long as someone does not know how to fix it.
  2. It should work out of the box for both the environments (unix, windows). Also, you can revert it on your repo easily. The ending ,s are senseless in the csv file anyway.