K5II settings definitions

[blemasle]

This PR adds settings definitions for the K5II.

I've used pktriggercord-cli.exe --settings_hex to save and compare hex values between each change. I just have one doubt. Does bulb_mode_press_press actually refers to Remote control in Bulb in the third setting configuration page on the camera ? I mean, there is no notion of the "remote" in the pktriggercord setting name.

With a bit of luck, these settings might also work for the K5IIs (maybe even the K5) as they are virtually identical.

I also have the hex files at hand if you ever need them to cross check my findings 😄

[asalamon74]

Thanks for the pull request.

bulb_mode_press_press is not about remote control. There is a 'Bulb (B)mode option' setting for K70 with two possible values: Type1, Type2. The setting can be found in C1.

This pictures shows the menu: http://www.ricoh-imaging.co.jp/english/support/qa/k-70/img/k-70_img_17.jpg

Could you please check K5II for a similar setting?

[blemasle]

The K5II has a similar setting with almost the exact same phrasing, but it applies only when controlling the shutter with a remote.

I'll have a look again after a weekend if it does change the behavior of the camera without a remote as well.

[blemasle]

So. The setting does refer to remote control exclusively. I wasn't able to test if it has any effect without a remote control, as changing the setting on the camera did not change the camera behaviour in bulb mode at all (with or without a remote, I had to hold the button to keep the shutter open).

Otherwise, the camera does not have another setting that dictate the shutter button behaviour while in Bulb mode.

See this album for camera screen captures.

[asalamon74]

Thanks for checking. In this case I think it would be better to delete bulb_mode_press_press from the change. Your field is a different one.

[blemasle]

Mmmmhh The K-x also works this way and is currently supported by the settings. See Remote control in bulb : http://www.ricoh-imaging.co.jp/english/support/man-pdf/k-x.pdf#G7.928126 (page 81, C2)

K-50 : Bulb mode http://www.ricoh-imaging.co.jp/english/support/man-pdf/k-50.pdf#G7.441578 (page 80, C2) k-70 : Bulb mode http://www.ricoh-imaging.co.jp/english/support/man-pdf/k-70.pdf#G4.1129535 (page 34, C1) K-01 : Bulb mode http://www.ricoh-imaging.co.jp/english/support/man-pdf/k-01.pdf#G7.531346 (page 72, C1)

Bulb mode applies either to the remote control or only to the regular shutter according to the wording. For cameras with the "Bulb mode" variants, I guess that setting also affects how the remote control behave. So in essence, it's the same setting, but it is restricted to the remote control for the K5, K5II and K-x. And it might just be a wording difference.

What do you think on that ?

[asalamon74]

K-x supports this field, but the definition of this setting ( https://github.com/asalamon74/pktriggercord/blob/master/pentax_settings.json#L17 ) is the following:

{ "name" : "bulb_mode_press_press", "type": "boolean", "value": "false" }

which means we don't read this from the settings, we use the hardwired value false because there is no way to change this field to true for K-x. As far as I understand, this is also true for K5II. There is no way to change the value of this, so it has a hardwired false value. For this pull request I suggest this.

It would be useful to introduce a new field remote_bulb_mode_press_press which should read the 'Remote control in bulb' values. This could read 0x0db for K5II and 0x132 for K-x.

[blemasle]

You're right, I didn't see that it was hardwired for the K-x. I can add a new setting of course. Do you want me to add it to the plsr_settings struct and add the relevant code in collect_settings_info as well ?

[asalamon74]

It would be great if you could also add the new field to every place. It should also be added to ipslr_settings_parser_json.

Maybe it's easier to add the new field in a separate pull request. Feel free to choose.

[blemasle]

Of course, I'm going to add that setting to every "mandatory" piece. I was asking about the optional ones. But I'll add it everywhere then :)

[blemasle]

All done. I added the setting at the last position in the struct to avoid breaking change on struct instantiation order. Let me know if you'd like me to set the setting at a more "logical" place, ie next to bulb_mode_press_press.

[asalamon74]

Thanks for the contribution, committed.