asalamon74 / pktriggercord

Remote control for Pentax DSLR cameras
http://pktriggercord.melda.info
GNU Lesser General Public License v3.0
103 stars 38 forks source link

Issue #46 #47

Closed FrankBijnen closed 4 years ago

FrankBijnen commented 4 years ago

Make pktriggercord-cli compile on Windows using RAD Studio 10.3

FrankBijnen commented 4 years ago

Thanks for the patch, I reviewed the files and sent a few comments. Mostly cleanups so it will be easier to maintain this change later.

One thing I'm missing is the Makefile change. Probably you user other ways to compile RAD10 and not the command line, that's OK. But there are a few make commands which is incomplete right now.

For instance make srczip creates a .tar.gz file containing all the source files, right now rad10 directory is missing from it.

About the Makefile.

thanx

asalamon74 commented 4 years ago

I've modified the Makefile, fixed a few astyle problems, added Changelog entry and committed the change.

Thanks for the patch.