asalamon74 / pktriggercord

Remote control for Pentax DSLR cameras
http://pktriggercord.melda.info
GNU Lesser General Public License v3.0
103 stars 38 forks source link

Libpktriggercord #48

Closed karlrees closed 4 years ago

karlrees commented 4 years ago

Initial support for library version.

These are the changes I made when I first tried to get the pktriggercord make file to compile a library version. I didn't get around to having it install the library or deal with packaging. I think part of the reason I eventually gave up was I wasn't quite sure what the preferred install/packaging behavior should be. That, and I didn't think the library would be very user-friendly without moving all of the code into a unique namespace, which I didn't feel up to doing at the time.

(The libpktriggercord package I eventually produced for INDI used a stripped down version of the source code and cmake to build/install. So that obviously wouldn't integrate well back into the original code base at the moment).

asalamon74 commented 4 years ago

Thanks @karlrees for the pull requestl. Added this to the libpktriggercord branch and opened an issue for that: #49 let's continue the discussion there, I close this pull request now.