search

asalamon74 / pktriggercord

Remote control for Pentax DSLR cameras
http://pktriggercord.melda.info
GNU Lesser General Public License v3.0
103 stars 38 forks source link

Added set_buffer_type and get_buffer_type commands to servermode, to enable downloading images as PEF instead of DNG #67

Closed kozinski closed 3 years ago

kozinski commented 3 years ago

It's useful to be able to download images in PEF rather than DNG, since PEF is compressed and DNG isn't (at least on older Pentax cameras), which is a benefit when downloading multiple images over USB 2.0. Since the buffer type is specified when actually reading the buffer rather than when releasing the shutter, it can be stored as a variable with no need to communicate with the camera when it's changed.

The default setting is DNG, so it shouldn't affect anything unless explicitly modified.

Tested on a Pentax K10D (connected to a Raspberry Pi 4B) and it seems to work as expected.

kozinski commented 3 years ago

Sorry, just realized I based this PR off the branch I submitted a PR for earlier (that adds set_aperture to servermode), so this one incorporates those changes against master as well. Let me know if you'd like me to resubmit this with only the buffer_type changes.

kozinski commented 3 years ago

I went ahead and removed the set_aperture changes from this branch, so it's now an independent change

asalamon74 commented 3 years ago

Thanks @kozinski committed: d28edc3f2f6e06985b47f3fb03b878ed36f9ef70