asam-ev / OpenMATERIAL

3D model exchange format with physical material properties for virtual development, test and validation of automated driving.
https://asam-ev.github.io/OpenMATERIAL/
Mozilla Public License 2.0
13 stars 7 forks source link

155 provide example for the material mapping #156

Closed ClemensLinnhoff closed 2 weeks ago

ClemensLinnhoff commented 1 month ago

Describe your changes

Issue ticket number and link

Fixes #155

Checklist before requesting a review

ClemensLinnhoff commented 1 month ago

@MatthiasThDs @ipg-jsc @ipg-sig @lyndyRott please also feel free to review this.

lyndyRott commented 4 weeks ago

looks like a good example to me. From the checker_xom.png (referring to red and blue material definitions) and the color-channels provided in the mapping table (referring to black and white texture names with red and blue rgb-values) it could be confusing to understand the mapping, if the chosen color values are mixed channel. Nevertheless, I can understand that these are the chosen IDs for the material mapping.

ClemensLinnhoff commented 4 weeks ago

looks like a good example to me. From the checker_xom.png (referring to red and blue material definitions) and the color-channels provided in the mapping table (referring to black and white texture names with red and blue rgb-values) it could be confusing to understand the mapping, if the chosen color values are mixed channel. Nevertheless, I can understand that these are the chosen IDs for the material mapping.

Thanks for your review. I can see how this might be confusing. But I actually deliberately chose other colors than black and white for the assignment texture to showcase, that these are just arbitrary mapping IDs and not the actual colors of the visual texture. I think we need to make this very clear in the documentation about the assignment/mapping.

KimuraDIVP commented 4 weeks ago

I think we'd better add the discription about assigning Matrial Mapping File (example_mapping.xomm) to Asset File (example_asset.xoma).

ClemensLinnhoff commented 3 weeks ago

I think we'd better add the discription about assigning Matrial Mapping File (example_mapping.xomm) to Asset File (example_asset.xoma).

You are right, thanks for the remark. I somehow missed that. I added it now as "materialMappingUri".