search

asam-ev / qc-framework

Mozilla Public License 2.0
13 stars 6 forks source link

Clean up the repo and remove Xodr/XoscSchemaChecker #54

Closed hoangtungdinh closed 1 month ago

hoangtungdinh commented 1 month ago

Description

This PR includes changes related to the first development phase of the ASAM Quality Checker project. The changes in this PR are ready for CCB's review.

The main changes are listed as a list of smaller PRs below. For the detailed code change per feature, please check in the individual PR.

Main changes

  1. 46

  2. 47

  3. 48

  4. 49

How was the PR tested?

Tests are documented in each PR listed above.

Notes

This PR will close the following issues

pmai commented 1 month ago

Sadly can't join the CCB due to illness, but PR looks good from my PoV.

MatteoRagni commented 1 month ago

I was not able to complete everything in review (I stopped after ~80 files), but I'm quite confident it is good. I've put some comments that reflect personal preferences in coding. Feel free to ingore them, in particoular if they are on automatic generated code from Xerces.

I'm not approving directly because I'm not able to test the PR code on my machine. If @andreaskern74 approves it, I will agree, also because he has a very deep understanding of the codebase that I'm lacking.

EDIT: @andreaskern74 approved it while I was rewieving :smiley: It was merged while I was reviewing... forget about the comments.

hoangtungdinh commented 1 month ago

Thanks a lot for the review @MatteoRagni . Please feel free to review the PRs, even if they are already closed. We also discussed in the CCB meeting today that reviews on closed PRs are welcome. They will be addressed in the future PRs.

If it's convenient for you, you could also do the code review in the "develop" PRs in the future, so that it's easier to follow the code changes. The only logical change we made to the code is the removal of xsd checker #49. The rest is code from the original codebase and your feedback is very helpful to improve it further.