asam-ev / qc-framework

Mozilla Public License 2.0
13 stars 6 forks source link

Needless attribute "fileType" in "FileLocationType" in result file format #99

Open andreaskern74 opened 5 days ago

andreaskern74 commented 5 days ago

Describe the bug

When reading https://github.com/asam-ev/qc-baselib-py/blob/main/README.md#writing-a-result-for-checker-results, I noticed that there is the IMHO needless attribute "fileType" in "FileLocationType" in the result file format.

https://github.com/asam-ev/qc-framework/blob/a001d452a2af33009ac0713616abd8d5924dab68/doc/schema/xqar_report_format.xsd#L80

Expected behavior

Should not be necessary, because the framework should be standard agnostic. So it should be removed.

Additionally, no major thing, but when we touch the file.... this describes the result format, not the report format. So, the filename should be xqar_result_format.xqar.

Screenshots

Stumbled also over it, because the file type is more "xodr" than "odr". Anyway... should not be needed in the format and in the APIs.

image

Additional context

Probably the ReportGUI is evaluating this? Because there are two GUI elements for XODR and for XOSC. But this could be "workarounded" until the two GUI elements are replaced by one common (see #23).

This is also somehow related to the closed issues #9, and #10.