Card Preview - Githubissues

Kamrulhasan12345 commented 4 months ago

Currently, hovering on items don't show card previews if this feature is enabled in about:config.

asamuzaK commented 4 months ago

asamuzaK commented 4 months ago

You must have the permission to use this method.

asamuzaK commented 4 months ago

Target Milestone: --- → 126 Branch

Release Date May 14, 2024

asamuzaK commented 4 months ago

Some notes:

Behavior
- The preview image is the thumbnail of the initial display, not the thumbnail of actual displayed area. Bug 1879089
- Does not preview active tab.
- Does not preview discarded tab either.
- Does not preview during drag and drop.
Layout
- Top row is the title, middle row is domain (without scheme) Bug 1879345, bottom row is preview image.
- domain not shown on about: schemes.
- Must be displayed in the sidebar so width of the preview will be very limited.
- The image will be considerably reduced.
- For example, if the tab is in the top half of the viewport (<50vh), display below the tab, and vice versa for the tabs in the bottom half?
- For rtl sites, maybe it needs to clip image from right, e.g. object-fit: cover; object-position: 100% 0; ATM, image is clipped from top left. Bug 1877837
Options page
- At least for now, the value of browser.tabs.cardPreview.enabled cannot be retrieved from browserSettings, so it needs to be set from an options page.
- For browsers below 126.0, require optional permission <all_urls>.
- activeTab is required by default.

It may be possible to implement, but the performance cost is likely to be quite high.

asamuzaK commented 4 months ago

Ref:

It seems that it is still in the early stages of implementation and is still under development. Let's wait and see.

asamuzaK / sidebarTabs