asamuzaK / withExEditorHost

Native messaging host for withExEditor
MIT License
33 stars 8 forks source link

script issue #120

Closed OrionRandD closed 8 months ago

OrionRandD commented 8 months ago

I am getting this error, using the script to install the host:

./index setup node:internal/modules/cjs/loader:1147 throw err; ^

Error: Cannot find module './xhr-sync-worker.js' Require stack:

Node.js v20.11.1

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

I have this module here: /home/vagner/.vscode/extensions/yzane.markdown-pdf-1.5.0/node_modules/jsdom/lib/jsdom/living/xhr-sync-worker.js

But, the script does not find it...

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

asamuzaK commented 8 months ago

Yeah, seems like a regression in Node.js v20.11.1

asamuzaK commented 8 months ago

Node.js v20.11.1 is a security fix, ref Node.js — Wednesday February 14 2024 Security Releases, so I have released a package that bundles it.

A temporary workaround is to revert to v8.0.0. The security issues are not patched, but since it is limited to the interaction between the host and the extension, I think it can be said that there is almost no risk.

OrionRandD commented 8 months ago

Node.js v20.11.1 is a security fix, ref Node.js — Wednesday February 14 2024 Security Releases, so I have released a package that bundles it.

A temporary workaround is to revert to v8.0.0. The security issues are not patched, but since it is limited to the interaction between the host and the extension, I think it can be said that there is almost no risk.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

Could you fix the script? I use it to install the host...

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

asamuzaK commented 8 months ago

Just overwrite your binary with v8.0.0

OrionRandD commented 8 months ago

Just overwrite your binary with v8.0.0

It is compressed in /tmp/withExEditorHost.tar.gz ??? And do do not see a place in the script where I can manually change to v8.0.0

asamuzaK commented 8 months ago
OrionRandD commented 8 months ago

Works, but still points to the new version

withExEditorHost New version v8.0.1 is available. And if someone tries to upgrade it will face the previous error... Thx

asamuzaK commented 8 months ago

It was a dependency issue.

asamuzaK commented 8 months ago

Released v8.0.5