search

asanetargoss / Changeling

Shapeshifting mod and morphing API for Minecraft
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/2656333-asanetargoss-miscellaneous-mods-changeling-and
Other
5 stars 2 forks source link

Fix #18: Avoid excessive velocities by limiting exponential gravity. #19

Closed James103 closed 4 years ago

James103 commented 4 years ago

The original implementation used unbounded exponential gravity, which could cause players to experience insane lag or even get kicked or crash due to the huge velocities involved after just a few seconds to minutes.

The new implementation reduces the strength of the exponential gravity as well as makes it taper off the faster you go downwards, thereby allowing for some exponential gravity without making it go too out of control with the velocities.

asanetargoss commented 4 years ago

Thanks for fixing this. It may take a while for this to get official builds up, as porting is a bit of a manual process, and I also have to do some maintenance in light of the change to Metamorph's update process. I don't foresee any issues, though.

asanetargoss commented 4 years ago

Per https://github.com/asanetargoss/Changeling/issues/18#issuecomment-612515746 , a new Changeling version has been released on GitHub with the fix, for compatibility reasons.

James103 commented 4 years ago

Are you still willing to port this change over to Metamorph?

asanetargoss commented 4 years ago

It's near the top of the Changeling TODO list, but first I want to do a bunch of git wizardry, since Metamorph's update process has changed. If I do not do this git wizardry stuff, it's going to get harder over time to share code between the projects.

It's not super hard but I'm not doing it at this very moment.

What are your priorities/needs right now? Is there a reason this needs to be integrated into the Metamorph codebase sooner rather than later?

Also, I will continue to review/merge pull requests for Changeling. (unless said pull request is an entire Metamorph branch)