search

asanghi / omniauth-constantcontact2

OmniAuth Strategy for Constant Contact using OAuth2
MIT License
5 stars 18 forks source link

Merge with omniauth-constantcontact gem #3

Open calebjclark opened 11 years ago

calebjclark commented 11 years ago

@Asanghi, I'm the developer of the omniauth-constantcontact gem. I see little reason to maintain both OAuth1 and OAuth2 gems for ConstantContact, especially now that CC has depreciated support for OAuth1. How about replacing my 'omniauth-constantcontact' gem with your version?

asanghi commented 11 years ago

Sounds okay to me! No point keeping the confusion of 2 around.

calebjclark commented 11 years ago

What's the best way to update the omniauth-contactcontact gem to use your OAuth2 version? Should I add you to the list of gem owners and let you push a version 2 of the gem?

michaelherold commented 9 years ago

Just wondered if you guys were still planning to merge these two gems or keep them separate. I'm going to incorporate this into a project and am looking for a heads-up on whether to expect a deprecation due to the merging of the two gems.

asanghi commented 9 years ago

Well there has been no conversation around this for over two years now. I'm not using this gem myself. Happy to let someone else take ownership and merge.

calebjclark commented 9 years ago

I don't use the gem either, but I'm happy to hand off whatever is needed for the merge.

pcai commented 9 years ago

Hi @asanghi - I'm happy to take ownership of this gem if you are still looking for someone to help with maintenance.

asanghi commented 9 years ago

Sounds great! Added @pcai to the repo. Do as you please!

pcai commented 9 years ago

@asanghi Thanks! Would you be able to add me as an owner on the rubygem as well, so I can publish new releases?

asanghi commented 9 years ago

@pcai i think i need your email address for that.

asanghi commented 9 years ago

..and done!

pcai commented 9 years ago

@calebclark I am a new collaborator on this gem and I agree it would be good to merge with yours, can you add me to it on github and rubygems? My gmail username is linker.error. I would be happy to take care of it for you. Or we can discuss details here if you like.

calebjclark commented 9 years ago

@pcai I have added you to both github and rubygems. Let me know if you need anything else.