asantibanez / livewire-charts

Neat Livewire Charts for your Laravel projects
MIT License
804 stars 120 forks source link

Error in console when leaving a page with a chart #115

Open DenisD3D opened 9 months ago

DenisD3D commented 9 months ago

Describe the bug When navigating from a page with a chart to another page, some error appear in the console (see screenshot). Tracking the source seems to be a resize event. Is the chart properly destroy when switching page ?

I'm using Livewire Volt (class based). That means there is no render function and so i'm creating the charts in the with function.

To Reproduce From a page with a chart, navigate to another page

Expected behavior No error in the console

Screenshots Resulting errors in the console image

Additional context Minimal Volt component for reproduction: test.blade.php

<?php

use Livewire\Volt\Component;
use Asantibanez\LivewireCharts\Models\ColumnChartModel;

new class extends Component {

    public function with(): array
    {
        return [
            'columnChartModel' => new ColumnChartModel()
        ];
    }
}; ?>
<div class="text-center">
    <div class="max-w-md m-auto">
        <livewire:livewire-column-chart key="{{ $columnChartModel->reactiveKey() }}" :column-chart-model="$columnChartModel"/>
    </div>
</div>

Solution Ideas Destroying the chart before leaving the page / unregistering the events

EPuigdemont commented 6 months ago

Adding to this, I also see this issue when using wire:navigate when there is a nested chart component in a view.

nikunj-7span commented 3 months ago

@DenisD3D I'm getting the same issue, Would you happen to have any idea how to solve it?

DenisD3D commented 3 months ago

No sorry, I think it's best to use a non volt component