Support for php 8.x - Githubissues

asantibanez / livewire-select

Livewire component for dependant and/or searchable select inputs

MIT License

501 stars 96 forks source link

Open hebinet opened 3 years ago

hebinet commented 3 years ago

Hello, thanks for this package! It would be nice if it is compatible with php 8.x

A simple "php": "^7.2|^8.0" in composer.json should be enough.

Kind regards.

ioanschmitt commented 3 years ago

Would be nice!

evertonpaiva commented 3 years ago

It woub be great! I'm waiting for it. Thanks!

niektenhoopen commented 3 years ago

There is already an unmerged PR for this: #16 (actually there is another PR: #15 but #16 is better)

bfiessinger commented 3 years ago

should be closed by e15bd41a0f913509b096ad99cbd6b1c462e0bf76

niektenhoopen commented 3 years ago

should be closed by e15bd41a0f913509b096ad99cbd6b1c462e0bf76

That's not for PHP8 support right?

bfiessinger commented 3 years ago

@niektenhoopen not only but php8 has been added there through the dependencies

niektenhoopen commented 3 years ago

@niektenhoopen not only but php8 has been added there through the dependencies

It's locked to PHP ^7.2 in the comment you refer to. That is 7.x and not 8.

bfiessinger commented 3 years ago

It's locked to PHP ^7.2 in the comment you refer to. That is 7.x and not 8.

oh.. I must have misread the line so.. But refering to the composer.json changes got applied in bb58c584c2637493e599851ad524df81bfd6dac7