search

asantoni / libaudiodecoder

The Cross-Platform Audio Decoder API
Other
128 stars 36 forks source link

inline methods (member functions) link issues #9

Open avinash-gupta-in opened 6 months ago

avinash-gupta-in commented 6 months ago

Many functions are inline, as we know in such case we have to provide the definition within the header file. We are getting link issues with such functions. https://stackoverflow.com/questions/953710/inline-function-linker-error

asantoni commented 6 months ago

Thanks for bringing this to my attention. You're right, but I won't have time to fix this for a week or two. I would accept a pull request that removes inline from all the functions, if you want to send one over. There's no need for them to be inline and I agree it's done incorrectly and will cause linker issues in some cases.