search

asapach / peerflix-server

Streaming torrent client for Node.js with web ui.
MIT License
1.31k stars 586 forks source link

Missing ffmpeg in docker image #122

Closed pryg-skok closed 6 years ago

pryg-skok commented 7 years ago

Hi, FFmpeg is missing in Docker image, so query params like ffmpeg=remux is not working here.

asapach commented 7 years ago

Yeah, it's an experimental feature, so I didn't think it would make sense to add it to Dockerfile. You can try adding it yourself by following these instructions: https://github.com/fluent-ffmpeg/node-fluent-ffmpeg#ffmpeg-and-ffprobe If that works out, a PR is welcome.

pryg-skok commented 7 years ago

I've created simple PR.

Also it's not clear of how to permanently store torrents.json file from container. And for now I've solved with couple lines in dockerfile:

RUN mkdir -p  /home/app/.config/peerflix-server && \
    echo "[]" > /home/app/.config/peerflix-server/torrents.json

And container starts with option: -v /path/to/torrents.json:/home/app/.config/peerflix-server/torrents.json

but maybe there is a better way? Maybe it can be configureable?

asapach commented 7 years ago

Thanks.

I think it would be better to mount /home/app/.config/peerflix-server folder, because it can also have config.json in it:

RUN mkdir -p  /home/app/.config/peerflix-server
 -v /path/to/config:/home/app/.config/peerflix-server

You can send a PR for Docker.md if you want.

How do you suggest making it more configurable?