search

asapach / peerflix-server

Streaming torrent client for Node.js with web ui.
MIT License
1.31k stars 586 forks source link

Use official node image in dockerfile #133

Closed sgsunder closed 6 years ago

sgsunder commented 6 years ago

Is there any reason why you're not using Docker's official node image in your dockerfile? i.e replacing FROM mhart/alpine-node:6 with FROM node:6-alpine.

The dockerfile builds and runs just as well with the change and I would assume that the official image is more secure.

sgsunder commented 6 years ago

Also, you can use apk --no-cache add instead of apk update && apk add ... && rm -fr /var/cache/apk. See this blog post

asapach commented 6 years ago

A PR is welcome.