search

asapach / peerflix-server

Streaming torrent client for Node.js with web ui.
MIT License
1.31k stars 586 forks source link

2 mp4 file when download one completed，there is no obvious indication that one of them has been downloaded. #164

Open JSZMonkey opened 5 years ago

JSZMonkey commented 5 years ago

When a seed file contains 2 mp4 files, I only download one. When one of the downloads is completed, there is no obvious indication that one of them has been downloaded.

asapach commented 5 years ago

Yeah, the only indication is that the checkbox next to the file becomes unchecked. It's the consequence of using torrent-stream under the hood, because it doesn't provide any kind of api for this. I was thinking that instead of unchecking the checkbox I could try to make it checked and disabled, like this: image Thoughts?

JSZMonkey commented 5 years ago

I think , don't add links without downloading and add Videos.mp4 tag, only have links to files when the file is downloaded and add . And add a single file delete button, when I click the wrong download, I can delete this file. And add the automatic transcoding function after the download is completed, and convert the video file format to mp4.

ps: like this

asapach commented 5 years ago

Sorry, but I disagree:

don't add links without downloading

The whole point of streaming torrents is that you don't need to download the whole file in order to access it. You can randomly seek inside the file that is partially downloaded.

add a single file delete button

Unfortunately files cannot be deleted once they are downloaded. You can only delete the entire torrent. That's how torrent clients are supposed to work, because they need to be able to seed the downloaded chunks.

add the automatic transcoding function

I've tried that a couple of years ago and it didn't work very reliably for real-time streaming, so I just gave up. I'm not planning to add any special handling for video files. I recommend using VLC to play the video files as network streams.

nk932714 commented 4 years ago

@asapach can't we replace the tick mark with This type of downloading GIF ? wip-bouncing-arrow-animation

and on downloading completion gif changes to this type of logo? image

asapach commented 4 years ago

@nk932714, the checkbox is meant to convey that the file is currently being downloaded (see here): if it's checked then somebody is interested in it (you can either check it manually, or it will activate automatically when streaming), otherwise it's idle. Replacing it with a gif won't make any functional difference and will only annoy people who hate animated gifs. I'll think about what can be done better when the download completes.