search

asapach / peerflix-server

Streaming torrent client for Node.js with web ui.
MIT License
1.31k stars 587 forks source link

Add Gitpod config, Update node version, Update some dependencies, Reduce logo size and Add github actions #176

Open chintan9 opened 4 years ago

chintan9 commented 4 years ago

Add Gitpod config, Update node version, Update some dependencies, Reduce logo size and Add github actions

This change is Reviewable

au5ton commented 4 years ago

boop @asapach

asapach commented 4 years ago

What's Gitpod and why should it be so prominently mentioned on the home page? I'm afraid that out of the 58 commits in this PR only a couple would make sense

pataquets commented 4 years ago

Skimming the commit log, I see some worthwhile changes, mainly dependencies upgrading. For the Gitpod concern, I've checked it and I think it won't hurt to have the button available, IMHO. It would ease contributing, which is always good. However, I agree on the fact that's too prominently placed, with no reason. Maybe placing it somewhere else, such as in the development markdown file would be a better place and would make more sense. @asapach If it makes sense to you, maybe @chintan9 can push a commit moving it. I checked out the Github 'network graph' and @chintan9 's fork has lots of commits which surely would be worthwhile to consider. What do you think?

asapach commented 4 years ago

Most of these changes are low hanging fruit, and can now be mostly automated using GitHub bots, so this PR of little value. However if somebody wants to create a new PR with a cleaner history, without bells and whistles, they are welcome.

pataquets commented 4 years ago

Are the changes good enough as they are? I mean, would just a squash be enough? I could give a stab at it, if they are. Unless @chintan9 beats me at it :) I would like the credit going to the OP.

asapach commented 4 years ago

You could cherry-pick the changes to package.json (+ package-lock.json) and .travis.yml, the rest are irrelevant.