asapach / peerflix-server

Streaming torrent client for Node.js with web ui.
MIT License
1.31k stars 586 forks source link

Search support, Dark mode, Video overlay (.mkv streaming) and Remember selected files #207

Closed Willy-JL closed 6 months ago

Willy-JL commented 2 years ago

Proposed changes:

Preview:

Notes:

asapach commented 2 years ago

I would definitely rather split these into multiple PRs.

Willy-JL commented 2 years ago

Fair enough. So I take it your main concern is the search feature and relying on third parties, while the other changes are ok? If that's the case I'll close this PR and make a new one with the relative changes removed, and keep the search feature on my fork. And how's the code quality? I tried my best but webdev is not my thing so I just kinda poked around until stuff started working...

asapach commented 2 years ago

Fair enough. So I take it your main concern is the search feature and relying on third parties, while the other changes are ok?

I'll need to review them, but I'm not against adding dark mode and updating fontawesome

And how's the code quality? I tried my best but webdev is not my thing so I just kinda poked around until stuff started working...

I would say it's not the "angular way", so I will need to review it more carefully