asascience / ott-coops

Project Tracking for OTT Co-Ops
1 stars 0 forks source link

NWPS Direction Layers have Color Palette Options #330

Closed jamesdoyle21 closed 2 years ago

jamesdoyle21 commented 2 years ago

This should not be an option, for any vector layer, correct? Or are the arrows themselves supposed to have the color scale?

image

jamesdoyle21 commented 2 years ago

OM1 does not have the color palette option

jamesdoyle21 commented 2 years ago

Wind does this too

image

kvmartin001 commented 2 years ago

@nguyandy does EDS support color palettes for this data? If not, I can just add a check for the layer type to disable the palette dropdown here.

nguyandy commented 2 years ago

I don't think it does, I'm not seeing palette options for any of the winds layer in OM1 either.

kvmartin001 commented 2 years ago

@jamesdoyle21 This was fixed in this PR: https://github.com/asascience/oceansmap-3/pull/208

Six of the direction layers in the Maracoos catalog are coming from EDS and they are fixed by my PR (sort of by accident) EDS only returns one style option for direction layers, and we decided to hide the dropdown if that is the case.

The other two are coming from pyXMS and should be able to change arrow color. I'm not seeing tiles for these right now, but their WMS Settings are correct

jamesdoyle21 commented 2 years ago

Niiiice