asascience / ott-coops

Project Tracking for OTT Co-Ops
1 stars 0 forks source link

Units not Updating for Water Temperature Layers and Not Showing in Settings Drawer #337

Closed jamesdoyle21 closed 2 years ago

jamesdoyle21 commented 2 years ago

All layers except Doppio Bottom do not update to F when switching to imperial

image

jamesdoyle21 commented 2 years ago

This is similar to #336

nguyandy commented 2 years ago

Related to this issue. https://github.com/asascience/ott-coops/issues/267

Doppio is a pxyms layer, so that's why its working. With EDS layers, OM3 doesn't know the unit type until we make a GFI request - and we need the unit type in order to do conversions.

We could add a hardcoded unit mapping for some eds layers for now, but it's not a permanent solution.

Same issue as https://github.com/asascience/ott-coops/issues/336

jamesdoyle21 commented 2 years ago

Ok, thanks Andy. We don't want to spend the time on this until a more permanent solution is available. I will take these off the sprint and combine with #336

jamesdoyle21 commented 2 years ago

image

jamesdoyle21 commented 2 years ago

Same with salinity, currents and waterlevel