asascience / ott-coops

Project Tracking for OTT Co-Ops
1 stars 0 forks source link

Allow User to Show Maritime Basemap Either RNC or ENC #438

Closed jamesdoyle21 closed 2 years ago

jamesdoyle21 commented 2 years ago

OceansMap Bug tracker line 55

The pint here is to give the user the option to display the maritime map they like.

The UI here will be to add another checkable item to the top of the basemap list. The user can only have RNC or ENC checked, never both.

Look:

[ ] Show Coastlines [ ] Show Maritime (RNC) [ ] Show Maritime (ENC)

ndellicarpini commented 2 years ago

I can work on this, but where do we get the tile urls for rnc & enc? Also which one are we using now?

mpiannucci commented 2 years ago

RNC https://github.com/asascience/oceansmap-3/blob/92bb49275fd84026a79232a371e221c363d96dca/frontend/src/config/ott-coops.tsx#L67

ENC https://github.com/asascience/oceansmap-3/blob/92bb49275fd84026a79232a371e221c363d96dca/frontend/src/config/maracoos.tsx#L82

We are using a different one for each of these clients. I kinda think its confusing to choose between them, but if they want it we can do it

jamesdoyle21 commented 2 years ago

Let's give both options to each of the clients for now. If, in the future, they only want one they can play around with both and let us know which they like better.

jamesdoyle21 commented 2 years ago

The user should only be able to have 1 of these selected at a time. So if they have 1 on and check the other, the first should turn off

ndellicarpini commented 2 years ago

I could make a checkbox that just says "Show Maritime" w/ a radio selection next to it for "RNC", "DNC" if that sounds good. If we are going to enforce using only 1 at a time we probably shouldn't leave them as checkboxes.

jamesdoyle21 commented 2 years ago

@ndellicarpini neither of these maritime layers seem to be working for me. Nothing is loading

mpiannucci commented 2 years ago

This is a noaa problem i think

jamesdoyle21 commented 2 years ago

This is working now. We still want to only let the user have 1 activated at a time though