Hide the Timeslider when User Displays Time Independent Layers

asascience / ott-coops

Project Tracking for OTT Co-Ops

1 stars 0 forks source link

Hide the Timeslider when User Displays Time Independent Layers #471

Closed jamesdoyle21 closed 2 years ago

jamesdoyle21 commented 2 years ago

For example, if a user activates a climatology layer with no other layers active, hide the timeslider to show that the data is not linked.

If the user has a time independent layer and time dependent layer active, keep the timeslider.

ndellicarpini commented 2 years ago

what is the default behavior then? does the timeslider show with no layers on the map?

mpiannucci commented 2 years ago

what is the default behavior then? does the timeslider show with no layers on the map? Hold off on this one, I did this for the zms branch I have coming in the next day or so

ndellicarpini commented 2 years ago

um ok so I kinda did some of this stuff w/ the layer refactor. This is the functionality in the layer refactor:

if !Config.timeslider.enabled -> timeslider never appears
else if Config.timeslider.enabled && Config.timeslider.autoTimeExtents -> timeslider only appears when time-dependent layers are on the map (w/ layer refactor its easy to check if layer is time dependent)
else -> timeslider is always shown

Let me know what you think of this behavior, it shouldn't be difficult to tweak

jamesdoyle21 commented 2 years ago

The timeslider is still showing with a climatology layer open on the map

ndellicarpini commented 2 years ago

The timeslider is only hidden for deployments that use the autoTimeExtents feature. I think the only version we have that uses autoTimeExtents is floodmap.

jamesdoyle21 commented 2 years ago

Got it and is that the only deployment we want to hide the timeslider in? I personally think it can stay up in the other instances when a time independent layer open even if it has no functionality.