search

asaskevich / govalidator

[Go] Package of validators and sanitizers for strings, numerics, slices and structs
MIT License
6.05k stars 555 forks source link

Go 1.10 beta changes to net/uri break irc://#channel@network URI validation #250

Closed logic closed 6 years ago

logic commented 6 years ago

Just a quick head's-up: Go 1.10 introduces changes to net/url which appear to break the unit tests for irc://#channel@network URIs on IsRequestURL and IsRequestURI.

Changing to irc:/// (three slashes, to formally omit hostname:port) works properly for those two tests (on both Go 1.9 and 1.10), but fails on IsURL (on both; the two-slash variant validates fine on both 1.9 and 1.10).

I haven't had a chance to dig into this beyond a quick "oh, my builds are failing, wonder what happened", but thought I'd pass this along sooner rather than later.

stapelberg commented 6 years ago

Specifically, this is upstream commit https://github.com/golang/go/commit/ba1018b4549f3edc257221cc8e49221255e03290#diff-9667474d33400190658e4758cf28dbf5

stapelberg commented 6 years ago

And this issue was discussed upstream at https://github.com/golang/go/issues/23657