Closed lfaoro closed 4 years ago
https://ccard-generator.com/bulk-generate/visa conflicting with https://www.validcreditcardnumber.com which is saying that added cards is not valid due to Luhn Algorithm
I've added tests and merged, but we need some investigation about https://ccard-generator.com/bulk-generate/visa
Looks like cards generated by this site don't follow default Luhn algorithm used to ensure that checksum is not broken.
Improving the IsCreditCard validation tests by adding more card brands, which reveals some card brands won't pass our validation logic.
Sorry about all the whitespace changes, it appears the file wasn't gofmt'ed. My changes start at L:1392: https://github.com/asaskevich/govalidator/compare/master...lfaoro:test-iscreditcard?expand=1#diff-bf215ece4e5166da723b1e19a0d6b1cdR1392
The cards are generates from: https://ccard-generator.com/bulk-generate/visa