refactored code :: added the string type to the URL constant to make …

asaskevich / govalidator

[Go] Package of validators and sanitizers for strings, numerics, slices and structs

MIT License

6k stars 556 forks source link

refactored code :: added the string type to the URL constant to make … #404

Closed skywalker2909 closed 1 year ago

skywalker2909 commented 3 years ago

Refactored code :: added the string type to the URL constant to make it consistent since all other constants in the group have a type assigned

Q	A
RFC	yes

Description

Tell us about why this change is necessary:

Are you refactoring code? Yes
- Why do you feel the refactor is necessary? To make it consistent since all other constants in the group have a type assigned
- What types of refactoring are you doing? Added the string type to the URL constant

skywalker2909 commented 3 years ago

@asaskevich / other approvers - Can someone please check this PR and merge it if you find this tiny little refactoring appropriate.

If not, then please provide me with some feedback.

Thanks!

sergeyglazyrindev commented 2 years ago

Hello guys! I forked this package cause owner disappeared. Hope, he will be back, but it would be easier to merge these changes back if he is back Link to my repo: create issue there and we'll discuss it.

skywalker2909 commented 2 years ago

@sergeyglazyrindev - thanks for letting me know. Is there only 1 owner of the original repo? Any other shared owners/admins that may be having access to merge and maintain the repo in the absence of the owner?