Open mrwcjoughin opened 3 years ago
This seems like a good non-breaking implementation for the issue lots of people are having. How can we get some reviews here?
Hello guys! I forked this package cause owner disappeared. Hope, he will be back, but it would be easier to merge these changes back if he is back Link to my repo: create issue there and we'll discuss it.
This feature is implemented as a new optional feature - it is not a breaking feature
You set it by calling the below method passing true:
govalidator.SetEmptyValueAllowed(true)
Description
This change is necessary because the user of this package should be able to validate empty values.
How do you reproduce it? Try and validate any empty value
What did you expect to happen? for this package to call our custom validator even if its an empty value
What actually happened? it does not call our custom validator - it returns false
Are you adding documentation? Yes I have updated the readme
Are you providing a QA improvement (additional tests, CS fixes, etc.) that does not change behavior? I have added 2 additional tests. This feature is implemented as a new optional feature - it is not a breaking feature
Explain why the changes are necessary: Because we should be able to validate empty values if we want to
TARGET THE master BRANCH Yes